linux-kernel - Re: x86 git acpi issue?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 May 2008 11:45:51 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Adrian Bunk <bunk@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>,
	linux-kernel@...r.kernel.org
Subject: Re: x86 git acpi issue?


* Thomas Gleixner <tglx@...utronix.de> wrote:

> On Sat, 3 May 2008, Adrian Bunk wrote:
> > Commit afcab879e4044f952b7a031d5fd504e0feb7df41 is the commit where Ingo 
> > both _reverts_ his patch you describe in the x86 tree and additionally 
> > moves pci-$(CONFIG_ACPI) in exactly the way that causes this breakage.
> > 
> > In the 4 hours between Ingo doing the += change and Ingo reverting his 
> > own patch in the x86 tree it was in a pull request to Linus, so the
> > "queued up" patch is in Linus' tree but reverted in the x86 tree.
> > 
> > I saw neither the patch changing the :='s to += on linux-kernel nor does 
> > "do not override the existing pci-y rule when adding visws or numaq 
> > rules." in the commit description give any indication what the actual 
> > problem was.
> > 
> > It's also not obvious why the revert with the subject "visws: build fix" 
> > also moved the pci-$(CONFIG_ACPI) causing this bug here.
> 
> Right. This Makefile is a nasty trap. I looked into it and the fix for 
> now is below. Long term this Makefile trickery needs to be cleaned up 
> to avoid trapping into this again.

Thanks Thomas, i messed up that commit - i should have known that the 
NUMAQ build fix looked _too_ easy ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/