linux-kernel - Re: [PATCH 17/56] microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805042159.55077.arnd@arndb.de>
Date:	Sun, 4 May 2008 21:59:53 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	monstr@...nam.cz
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	stephen.neuendorffer@...inx.com, John.Linn@...inx.com,
	john.williams@...alogix.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 17/56] microblaze_v2: checksum support

On Sunday 04 May 2008, monstr@...nam.cz wrote:
> + *
> + * INET                An implementation of the TCP/IP protocol suite for the LINUX
> + *             operating system.  INET is implemented using the  BSD Socket
> + *             interface as the means of communication with the user level.
> + *
> + *             IP/TCP/UDP checksumming routines
> + *
> + * Authors:    Jorge Cwik, <jorge@...er.satlink.net>
> + *             Arnt Gulbrandsen, <agulbra@....unit.no>
> + *             Tom May, <ftom@...com.com>
> + *             Andreas Schwab, <schwab@...an.informatik.uni-dortmund.de>
> + *             Lots of code moved from tcp.c and ip.c; see those files
> + *             for more names.

This is a pretty generic implementation, and you copied it from another
architecture. How about moving it from arch/microblaze/lib/ to lib/?
I'd suggest building it conditionally under CONFIG_GENERIC_CSUM,
which you def_bool in your architecture Kconfig.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/