linux-kernel - Re: [PATCH 1/2] OF: clean coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <481D711E.6000003@seznam.cz>
Date:	Sun, 04 May 2008 10:17:34 +0200
From:	Michal Simek <monstr@...nam.cz>
To:	Joe Perches <joe@...ches.com>
CC:	monstr@...nam.cz, paulus@...ba.org, arnd@...db.de,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/2] OF: clean coding style - prom_parse.c

Hi All,

I fixed only part of coding style violation. Not all of them.

But you are right KERN_<level> is necessary.

For me is especially important to move these files from arch/powerpc to drivers/of.

M

>>  /* Debug utility */
>>  #ifdef DEBUG
>>  static void of_dump_addr(const char *s, const u32 *addr, int na)
>>  {
>> -	printk("%s", s);
>> -	while(na--)
>> -		printk(" %08x", *(addr++));
>> -	printk("\n");
>> +	printk(KERN_INFO "%s", s);
>> +	while (na--)
>> +		printk(KERN_INFO " %08x", *(addr++));
>> +	printk(KERN_INFO "\n");
>>  }
> 
> You've prefixed KERN_INFO before every address block.
> 
> How about:
> 
> print_hex_dump(KERN_<level>, s, DUMP_PREFIX_NONE, 4, addr, na, false);
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/