lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 04 May 2008 10:20:35 +0200 From: Michal Simek <monstr@...nam.cz> To: Arnd Bergmann <arnd@...db.de> CC: paulus@...ba.org, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org Subject: Re: [PATCH 1/2] OF: Fix coding style violation in of_device.c and of_platform.c Hi Arnd, this is question to powerpc guys not to me. I haven't tried to compiled but I think dcr.h is important header for powerpc. I only fixed problem for Microblaze because we don't have these headers. M >> >> #include <asm/errno.h> >> + >> +#ifdef CONFIG_PPC_PSERIES >> #include <asm/dcr.h> >> +#endif >> > > The patch looks basically good, but we normally try to not have an #include > inside of #ifdef. If the file builds without this #include, maybe you should > better leave it out entirely? Same for the ppc-pci.h in the other file. > > Arnd <>< > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists