lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 4 May 2008 10:48:21 +0200 From: Ingo Molnar <mingo@...e.hu> To: Vegard Nossum <vegard.nossum@...il.com> Cc: Roman Zippel <zippel@...ux-m68k.org>, Adrian Bunk <bunk@...nel.org>, Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] kconfig: warn about complex selects * Vegard Nossum <vegard.nossum@...il.com> wrote: > Hi, > > Given recent discussion about kconfig and the "select" feature, I have made > the following quick & dirty patch to detect what I call "complex selects". > > For v2.6.25, I get these warnings: > sound/pci/Kconfig:512:error: found complex select: SND_FM801_TEA575X -> VIDEO_V4L1 > drivers/ide/Kconfig:890:error: found complex select: ETRAX_IDE -> BLK_DEV_IDEDMA > drivers/acpi/Kconfig:185:error: found complex select: ACPI_HOTPLUG_CPU -> ACPI_CONTAINER > > While for v2.6.26-rc1, I get these: > sound/pci/Kconfig:528:error: found complex select: SND_FM801_TEA575X -> VIDEO_V4L1 > drivers/media/video/em28xx/Kconfig:2:error: found complex select: VIDEO_EM28XX -> MEDIA_TUNER > drivers/media/video/bt8xx/Kconfig:2:error: found complex select: VIDEO_BT848 -> MEDIA_TUNER > drivers/media/video/saa7134/Kconfig:2:error: found complex select: VIDEO_SAA7134 -> MEDIA_TUNER > drivers/media/video/cx88/Kconfig:2:error: found complex select: VIDEO_CX88 -> MEDIA_TUNER > drivers/media/video/cx23885/Kconfig:2:error: found complex select: VIDEO_CX23885 -> MEDIA_TUNER > drivers/media/video/ivtv/Kconfig:2:error: found complex select: VIDEO_IVTV -> MEDIA_TUNER > drivers/media/video/cx18/Kconfig:2:error: found complex select: VIDEO_CX18 -> MEDIA_TUNER > drivers/media/video/pvrusb2/Kconfig:2:error: found complex select: VIDEO_PVRUSB2 -> MEDIA_TUNER > drivers/media/video/Kconfig:690:error: found complex select: VIDEO_MXB -> MEDIA_TUNER > drivers/media/video/usbvision/Kconfig:2:error: found complex select: VIDEO_USBVISION -> MEDIA_TUNER > drivers/acpi/Kconfig:188:error: found complex select: ACPI_HOTPLUG_CPU -> ACPI_CONTAINER > > (In other words, the number of these has increased significantly since > the last release, and these will probably be hit as compile errors at > one point or another.) wow - these are exactly the problems that have been implicated statistically via all the build failures. and this concurs with my observation about build failures in this cycle - 2.6.26 showed a sharp rise in Kconfig space build problems. (and i've been doing random build tests for a long time) so your patch is pure gold. A thirty-line quick hack like this if implemented years ago could have avoided dozens and dozens of build failures and anguish to users, and we'd have lots less trivial patches littering the commit logs (and wasting maintainer and review bandwidth) as well. (because maintainers could act on these messages right when they introduce the select complexity, avoiding such bugs right at their source.) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists