[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080504114225.GA19074@uranus.ravnborg.org>
Date: Sun, 4 May 2008 13:42:25 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Vegard Nossum <vegard.nossum@...il.com>
Cc: Ingo Molnar <mingo@...e.hu>, Roman Zippel <zippel@...ux-m68k.org>,
Adrian Bunk <bunk@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kconfig: warn about complex selects
On Sun, May 04, 2008 at 01:00:38PM +0200, Vegard Nossum wrote:
> Okay, here's try #2. (That's what I get for making patches too early in the
> morning.)
>
> This checks dependencies instead of the "default" property. I don't know how
> useful this is, though, as it will generate some false positives. Actually,
> a lot of them.
Consider following simple Kconfig:
config A
bool "a"
config B
bool "b"
depends on A
config C
bool "c"
select B
config D
bool "d"
depends on A
select B
We should try to coe up with something that warns on
on the select in "config C", because B has dependencies C
does not have.
The select in D is OK since D has at least the same dependencies
as B.
So if we had a expr_is_subset_of(expr *e1, expr *e2)....
Roman - what do you think?
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists