linux-kernel - Re: [PATCH 36/56] microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2008 08:45:35 +0200 (CEST)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	John Williams <john.williams@...alogix.com>
cc:	monstr@...nam.cz, linux-kernel@...r.kernel.org, arnd@...db.de,
	linux-arch@...r.kernel.org, stephen.neuendorffer@...inx.com,
	John.Linn@...inx.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 36/56] microblaze_v2: dma support

On Mon, 5 May 2008, John Williams wrote:
> > +++ b/include/asm-microblaze/scatterlist.h
> > @@ -0,0 +1,21 @@
> > +/*
> > + * include/asm-microblaze/scatterlist.h
> > + *
> > + * This file is subject to the terms and conditions of the GNU General Public
> > + * License. See the file "COPYING" in the main directory of this archive
> > + * for more details.
> > + *
> > + * Copyright (C) 2006 Atmark Techno, Inc.
> > + */
> > +
> > +#ifndef _ASM_MICROBLAZE_SCATTERLIST_H
> > +#define _ASM_MICROBLAZE_SCATTERLIST_H
> > +
> > +struct scatterlist {
> > +	unsigned long page_link;
> > +	unsigned int	offset;
> > +	dma_addr_t	dma_address;
> > +	unsigned int	length;
> > +};
> > +
> > +#endif /* _ASM_MICROBLAZE_SCATTERLIST_H */
> 
> Is this worthy of promotion to asm-generic/scatterlist.h?

after moving dma_address one position up in the structure, as dma_addr_t may be
64-bit?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/