linux-kernel - Re: [patch] irda: fix !PNP support in drivers/net/irda/nsc-ircc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 May 2008 01:02:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mingo@...e.hu
Cc:	linux-kernel@...r.kernel.org, samuel@...tiz.org,
	dtor_core@...ritech.net
Subject: Re: [patch] irda: fix !PNP support in drivers/net/irda/nsc-ircc.c

From: Ingo Molnar <mingo@...e.hu>
Date: Mon, 5 May 2008 09:58:23 +0200

> i just used the existing precedent of doing the #ifdef: it's not _that_ 
> bad as it surrounds a single function most of the time so it's rather 
> apparent what is happening - and that is what is done in some other 
> drivers as well.
> 
> btw., when i fixed this i almost implemented it the way that you 
> suggested, but there's also a code size argument to when the suspend 
> callbacks are not used: the extra dummy function takes up text space, 
> and people turn off PNP when they build some specialized thing and try 
> to reduce the size of the kernel.
> 
> but in any case, i have no strong feelings in either direction.

The existing practice is ugly :-)

But I see arguments for either side, just like you.

Meanwhile let's fix this build error, I'll toss your patches
into my net-2.6 tree.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/