[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 5 May 2008 10:30:09 +0200
From: DM <dm.n9107@...il.com>
To: "Ulrich Drepper" <drepper@...hat.com>
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
linux-mips@...ux-mips.org, sparclinux@...r.kernel.org,
torvalds@...ux-foundation.org
Subject: Re: [PATCH v2] unify sys_pipe implementation
On Sat, May 3, 2008 at 8:01 PM, Ulrich Drepper <drepper@...hat.com> wrote:
[...]
> /*
> + * sys_pipe() is the normal C calling standard for creating
> + * a pipe. It's not the way Unix traditionally does this, though.
> + */
> +asmlinkage long sys_pipe(int __user *fildes)
> +{
> + int fd[2];
> + int error;
> +
> + error = do_pipe(fd);
> + if (!error) {
> + if (copy_to_user(fildes, fd, sizeof(fd)))
> + error = -EFAULT;
> + }
> + return error;
> +}
> +
[...]
I realize this code is old, but wouldn't file descriptors leak if
copy_to_user fails?
BR,
dm.n9107
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists