linux-kernel - Re: [PATCH] modpost: i2c aliases need no trailing wildcard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2008 10:48:16 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Linux I2C <i2c@...sensors.org>
Subject: Re: [PATCH] modpost: i2c aliases need no trailing wildcard

Hi Rusty,

On Mon, 5 May 2008 10:09:05 +1000, Rusty Russell wrote:
> On Saturday 03 May 2008 04:37:21 Jean Delvare wrote:
> > Hi all,
> >
> > [Once more with Sam's address fixed, sorry for the noise.]
> >
> > Not all device types need a wildcard at the end of their module
> > aliases. In particular, for i2c module aliases, the trailing wildcard
> > is not only unneeded, it could also cause the wrong driver to be
> > loaded.
> 
> Hi Jean,
> 
>    i2c would have been better using a terminator char after the device name.  
> The wildcard would then allow future extensions without having the current 
> potential confusion.

This has been discussed already:
http://lists.lm-sensors.org/pipermail/i2c/2008-April/003429.html

I understand that the idea of the trailing wildcard was to allow for
future extensions, however in the case of i2c I can't foresee any such
extension. On top of that, it really only matters for external drivers
(for in-tree drivers, if the alias format changes, the drivers will
also be updated so no harm done) and I don't think external drivers are
worth the effort and cost of anticipating a change which most certainly
will never happen.

> Still, there's nothing wrong with this patch, happy for you to send it.
> 
> Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks,
-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/