linux-kernel - Re: [patch 03/15] cgroup: dont call vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2008 07:00:16 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, hch@...radead.org,
	viro@...IV.linux.org.uk, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, Paul Menage <menage@...gle.com>
Subject: Re: [patch 03/15] cgroup: dont call vfs_mkdir

On Mon, May 05, 2008 at 11:54:44AM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> cgroup_clone() calls vfs_mkdir() to create a directory in the cgroup
> filesystem.  Replace with explicit call to cgroup_mkdir() and
> fsnotify_mkdir().
> 
> This is equivalent, except that the following functions are not called
> before cgroup_mkdir():
> 
>  - may_create()
>  - security_inode_mkdir()
>  - DQUOT_INIT()
> 
> Permission to clone the cgroup has already been checked in
> copy_namespaces() (requiring CAP_SYS_ADMIN).  Additional file system
> related capability checks are inappropriate and confusing.
> 
> The quota check is unnecessary, as quotas don't make any sense for
> this filesystem.

Looks correct but I don't think it's a good idea.  Spreading more logic
into filesystems without a good reason is rarely a good idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/