linux-kernel - Re: [patch 03/15] cgroup: dont call vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2008 09:08:04 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	hch@...radead.org, akpm@...ux-foundation.org,
	viro@...IV.linux.org.uk, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, menage@...gle.com
Subject: Re: [patch 03/15] cgroup: dont call vfs_mkdir

On Mon, May 05, 2008 at 02:32:22PM +0200, Miklos Szeredi wrote:
> > Looks correct but I don't think it's a good idea.  Spreading more logic
> > into filesystems without a good reason is rarely a good idea.
> 
> (Thanks for the review, Christoph)
> 
> Agreed completely, but vfs_* aren't for filesystems to call, rather
> for entities calling _into_ filesystems from the outside.  This is
> actually a very rare thing, so adding some extra logic for the sake of
> cleanliness should be OK.
> 
> Now it can be argued, that cgroup_clone() is calling into the
> filesystem from the outside.  But it's not really doing that, rather
> it's making an internal modification to a specific filesystem,
> triggered by some external action.

I don't think that matters. We're not about overly strict layering, and
especialy this kind where you call into a higher layer to get back into
the lower one is not harmful at all.  For cgroup it's only a small
duplication, but e.g. I don't really like all the duplications in the
reiserfs case.  Unless we have a very good reason why the useage of the
vfs_ function should go away from the filesystem code I don't think
we want this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/