[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 05 May 2008 16:20:51 +0200
From: Michal Simek <monstr@...nam.cz>
To: John Williams <john.williams@...alogix.com>
CC: linux-kernel@...r.kernel.org, arnd@...db.de,
linux-arch@...r.kernel.org, stephen.neuendorffer@...inx.com,
John.Linn@...inx.com, matthew@....cx, will.newton@...il.com,
drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
grant.likely@...retlab.ca, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 13/56] microblaze_v2: PVR support, cpuinfo support
FIXED.
>> +int cpu_has_pvr(void)
>> +{
>> + unsigned flags;
>> + unsigned pvr0;
>> + int ret = 0;
>> +
>> + local_irq_save(flags);
>> +
>
> ...
>
>> +out:
>> + local_irq_restore(flags);
>> + return ret;
>> +}
>
> The actual IRQ clear/restore is not required - can you just use
> local_save_flags() or similar to read the MSR?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists