linux-kernel - Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2008 21:55:48 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Peter Oberparleiter <peter.oberparleiter@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, ltp-list@...ts.sourceforge.net,
	ltp-coverage@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute paths only

On Mon, May 05, 2008 at 05:24:16PM +0200, Peter Oberparleiter wrote:
> From: Peter Oberparleiter <peter.oberparleiter@...ibm.com>
> Signed-off-by: Peter Oberparleiter <peter.oberparleiter@...ibm.com>
> ---
>  scripts/Kbuild.include |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.26-rc1/scripts/Kbuild.include
> ===================================================================
> --- linux-2.6.26-rc1.orig/scripts/Kbuild.include
> +++ linux-2.6.26-rc1/scripts/Kbuild.include
> @@ -144,7 +144,7 @@ ld-option = $(call try-run,\
>  build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
>  
>  # Prefix -I with $(srctree) if it is not an absolute path.
> -addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
> +addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))
>  
>  # Find all -I options and call addtree
>  flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o)))

We try to make all paths relative so less files get rebuild if you access the
same source from two different paths (think nfs mounted src etc).
So you really need to justify this change.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/