[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 May 2008 05:11:10 +0900
From: "KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>
To: "Adrian Bunk" <bunk@...nel.org>
Cc: wli@...omorphy.com, linux-kernel@...r.kernel.org,
"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [2.6 patch] mm/hugetlb.c: fix duplicate variable
> It's confusing that set_max_huge_pages() contained two different
> variables named "ret", and although the code works correctly this should
> be fixed.
>
> The inner of the two variables can simply be removed.
^^^^
two?
I think removal inner variable is 1, no?
but, your change is perfectly right, IMHO.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> while (count > persistent_huge_pages) {
> - int ret;
> /*
> * If this allocation races such that we no longer need the
> * page, free_huge_page will handle it by freeing the page
> * and reducing the surplus.
> */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists