[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Mon, 5 May 2008 22:25:08 +0200
From: Holger Macht <hmacht@...e.de>
To: linux-acpi@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, kristen.c.accardi@...el.com
Subject: [PATCH] bay: Exit if notify handler cannot be installed
If acpi_install_notify_handler() for a bay device fails, the bay driver is
superfluous. Most likely, another driver (like libata) is already caring
about this device anyway. Furthermore,
register_hotplug_dock_device(acpi_handle) from the dock driver must not be
called twice with the same handler. So clean up and exit.
Signed-off-by: Holger Macht <hmacht@...e.de>
---
diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
index d2fc941..ce9038f 100644
--- a/drivers/acpi/bay.c
+++ b/drivers/acpi/bay.c
@@ -311,6 +311,7 @@ static int bay_add(acpi_handle handle, int id)
bay_notify, new_bay);
if (ACPI_FAILURE(status)) {
printk(KERN_ERR PREFIX "Error installing bay notify handler\n");
+ goto bay_add_err;
}
/* if we are on a dock station, we should register for dock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists