linux-kernel - Re: Linux 2.6.26-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080506095122.860796f6.sfr@canb.auug.org.au>
Date:	Tue, 6 May 2008 09:51:22 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andreas Mohr <andi@...as.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: Linux 2.6.26-rc1

On Mon, 5 May 2008 09:30:31 +0200 Ingo Molnar <mingo@...e.hu> wrote:
>
> Subject: irda: PNP support for drivers/net/irda/nsc-ircc.c
> From: Ingo Molnar <mingo@...e.hu>
> Date: Sat May 03 21:21:13 CEST 2008
> 
> x86.git testing found the following build failure in latest -git:
> 
>  drivers/built-in.o: In function `nsc_ircc_pnp_probe':
>  nsc-ircc.c:(.text+0xdf1b6): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf1d4): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf1ee): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf237): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf24c): undefined reference to `pnp_get_resource'
>  drivers/built-in.o:nsc-ircc.c:(.text+0xdf266): more undefined references to `pnp_get_resource' follow
>  make: *** [.tmp_vmlinux1] Error 1

This was discovered in linux-next and a patch posted on March 28 ...

From: Bjorn Helgaas <bjorn.helgaas@...com>
Subject: [patch] nsc-ircc: wrap PNP probe code in #ifdef CONFIG_PNP
Date: Fri, 28 Mar 2008 10:54:43 -0600
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
        Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, Samuel Ortiz <samuel@...tiz.org>,
        irda-users@...ts.sourceforge.net, linux-next@...r.kernel.org

> Subject: irda: !PNP support for drivers/net/irda/smsc-ircc2.c
> From: Ingo Molnar <mingo@...e.hu>
> Date: Sun May 04 00:12:12 CEST 2008
> 
> x86.git testing found this build bug on v2.6.26-rc1:
> 
>   ERROR: "pnp_get_resource" [drivers/net/irda/smsc-ircc2.ko] undefined!
>   make[1]: *** [__modpost] Error 1
>   make: *** [modules] Error 2

As was this:

From: Bjorn Helgaas <bjorn.helgaas@...com>
To: Andrew Morton <akpm@...ux-foundation.org>
Subject: [patch] smsc-ircc2: wrap PNP probe code in #ifdef CONFIG_PNP
Date: Fri, 28 Mar 2008 10:53:06 -0600
User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405)
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
        Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, Samuel Ortiz <samuel@...tiz.org>,
        irda-users@...ts.sourceforge.net, linux-next@...r.kernel.org

I (and I assume Andrew) have been carrying them since then but noone took
them up.  I guess (as Andrew pointed out to me) I should have pushed them.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped