linux-kernel - Re: [-mm][PATCH 3/5] change function prototype of shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2008 13:42:47 +0900
From:	"minchan Kim" <barrioskmc@...il.com>
To:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [-mm][PATCH 3/5] change function prototype of shrink_zone()

>  -static unsigned long shrink_zone(int priority, struct zone *zone,
>  -                               struct scan_control *sc)
>  +static int shrink_zone(int priority, struct zone *zone,
>  +                      struct scan_control *sc)
>   {
>         unsigned long nr_active;
>         unsigned long nr_inactive;
>  @@ -1236,8 +1239,9 @@ static unsigned long shrink_zone(int pri
>                 }
>         }
>
>  +       sc->nr_reclaimed += nr_reclaimed;
>         throttle_vm_writeout(sc->gfp_mask);
>  -       return nr_reclaimed;
>  +       return 0;
>   }

I am not sure this is right.
I might be wrong if this patch is depended on another patch.

As I see, shrink_zone always return 0 in your patch.

If it is right, I think that return value is useless. It is better
that we change function return type to "void"
Also, we have to change functions that call shrink_zone properly. ex)
balance_pgdat, __zone_reclaim
That functions still use number of shrink_zone's reclaim page

-- 
Thanks,
barrios
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/