linux-kernel - Re: acpi_cpu_freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87prrzdhx4.fsf@duaron.myhome.or.jp>
Date:	Tue, 06 May 2008 16:13:11 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Greg KH <gregkh@...e.de>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Len Brown <lenb@...nel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-acpi <linux-acpi@...r.kernel.org>
Subject: Re: acpi_cpu_freq_init warning...

Greg KH <gregkh@...e.de> writes:

> On Tue, May 06, 2008 at 03:29:55PM +0900, OGAWA Hirofumi wrote:
>> > calling  acpi_cpufreq_init+0x0/0x68()
>> > sysdev: class cpu: driver (ffffffff80da0110) has already been
>> > registered to a class, something is wrong, but will forge on!
>> > ------------[ cut here ]------------
>> > WARNING: at drivers/base/sys.c:183 sysdev_driver_register+0x82/0x150()
>> > Modules linked in:
>> > Pid: 1, comm: swapper Not tainted
>> > 2.6.26-rc1-sched-devel.git-x86-latest.git-00485-g253148c-dirty #333
>> 
>> I've seen this too. The following patch seems to work for me.
>> -- 
>> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
>> 
>> 
>> [PATCH] Fix bogus warning in sysdev_driver_register()
>> 
>> 	if ((drv->entry.next != drv->entry.prev) ||
>> 	    (drv->entry.next != NULL)) {
>> 
>> warns list_empty(&drv->entry).
>
> should we just call list_empty() here to make sure it is correct?

Unfortunately we can't. drv->entry is initialized by NULL like following.

static struct sysdev_driver cpufreq_sysdev_driver = {
	.add		= cpufreq_add_dev,
	.remove		= cpufreq_remove_dev,
	.suspend	= cpufreq_suspend,
	.resume		= cpufreq_resume,
};

I assumed this (for compatible) is an intent.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/