linux-kernel - Re: [rfc] the kernel workflow & trivial "global -> static" patches (was: Re: [2.6 patch] make sched_feat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080506074636.GA27480@shadowen.org>
Date:	Tue, 6 May 2008 08:46:55 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Adrian Bunk <bunk@...nel.org>, mingo@...e.hu,
	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, sam@...nborg.org,
	viro@....linux.org.uk, hpa@...or.com
Subject: Re: [rfc] the kernel workflow & trivial "global -> static" patches (was: Re: [2.6 patch] make sched_feat_{names,open} static)

On Mon, May 05, 2008 at 02:46:25PM -0700, Arjan van de Ven wrote:
> On Mon, 5 May 2008 14:26:04 -0700
> Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > Actually, we could perhaps do a lot of this at the checkpatch level?
> > If checkpatch sees a global symbol being added and the same patch
> > does not add references to that symbol from a different file then
> > whine.  Obviously this will generate false positives but that's OK.
> 
> or.. doesn't add it to a header file. That might be even more generic;
> (and enforces a "all global functions need a prototype in a header
> somewhere)

That does sound possible.  I am sure it will false positive quite a lot,
but its probabally worth a stab.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/