linux-kernel - Re: Linux 2.6.26-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805060902.25835.alistair@devzero.co.uk>
Date:	Tue, 6 May 2008 09:02:25 +0100
From:	Alistair John Strachan <alistair@...zero.co.uk>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	Robin Holt <holt@....com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.26-rc1

On Monday 05 May 2008 22:04:17 Mauro Carvalho Chehab wrote:
> Alistair,
>
> Sorry for not answering earlier, I got some days off (I still didn't read
> all messages from you - I'm flooded of messages here).
>
> >> I have DVB_CORE=n and VIDEO_DEV=y. VIDEO_DEV is:
> >>
> >> config VIDEO_DEV
> >>         tristate "Video For Linux"
> >>
> >> So if you enable Video For Linux, the tuner-core is automatically built,
> >> even if no tuners are selected? Surely that's wrong..
> >
> > That is probably correct.  Video For Linux is used for capturing video
> > streams.  The fact that you can get this invalid config to fail to build
> > should be reported to the v4l folks and let them fix it up.
>
> Yes, this is correct, if you select a board that supports tuner (for
> example, bttv, or cx88).
>
> The error is that most tuners are dependent of I2C. The right fix seems to
> do this:
>
>
> config MEDIA_TUNER
>          tristate
>          default (DVB_CORE || VIDEO_DEV) && I2C
>          depends on (DVB_CORE || VIDEO_DEV) && I2C

This still seems imperfect -- if I have I2C=y and VIDEO_DEV=y, but DVB_CORE=n 
(and no board types selected), it'll still build at least some of the tuner 
code into the V4L core.

This is still true even if I set MEDIA_TUNER_CUSTOMIZE=y and set all of the 
tuners to 'n'. I'd assumed that this was an artefact of the complex Kconfig 
logic here, and was not intentional.

Thanks for fixing the compile issue though, I've confirmed that it works.

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/