linux-kernel - Re: [PATCH 02/56] microblaze_v2: Makefiles for Microblaze cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48201C23.1040609@seznam.cz>
Date:	Tue, 06 May 2008 10:51:47 +0200
From:	Michal Simek <monstr@...nam.cz>
To:	John Williams <john.williams@...alogix.com>
CC:	linux-kernel@...r.kernel.org, arnd@...db.de,
	linux-arch@...r.kernel.org, stephen.neuendorffer@...inx.com,
	John.Linn@...inx.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 02/56] microblaze_v2: Makefiles for Microblaze cpu

Hi John,

>> --- /dev/null
>> +++ b/arch/microblaze/Makefile
>> @@ -0,0 +1,63 @@
>> +UTS_SYSNAME = -DUTS_SYSNAME=\"uClinux\"
>> +
>> +# What CPU vesion are we building for, and crack it open
>> +# as major.minor.rev
>> +CPU_VER=$(subst ",,$(CONFIG_XILINX_MICROBLAZE0_HW_VER) )
>> +CPU_MAJOR=$(shell echo $(CPU_VER) | cut -d '.' -f 1)
>> +CPU_MINOR=$(shell echo $(CPU_VER) | cut -d '.' -f 2)
>> +CPU_REV=$(shell echo $(CPU_VER) | cut -d '.' -f 3)
> 
> No doubt there's some cleaner shell-fu to do this but I'm not
> complaining as I'm responsible for the original yucky version!

I think you told me that toolchain can use this flags. This is not pain for now.
I'll add to my future plans.

>> --- /dev/null
>> +++ b/arch/microblaze/platform/Makefile
>> @@ -0,0 +1,3 @@
>> +#
>> +# Makefile for arch/microblaze/platform directory
>> +#
> 
> How about a single 
> 
> obj-$(CONFIG_PLATFORM_GENERIC) += generic/
> 
> to show how platform-specific setup code can be added (even though
> there's none in the default generic target)?

We'll add this to Microblaze readme file. Chapter: how to add platform specific
files.

M

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/