linux-kernel - Re: [patch 4/4] x86: e820 unification: Extract common functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080506123229.GL32591@elte.hu>
Date:	Tue, 6 May 2008 14:32:29 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Christoph Lameter <clameter@....com>, travis@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 4/4] x86: e820 unification: Extract common functions


* Adrian Bunk <bunk@...nel.org> wrote:

> >  int
> > -e820_any_mapped(u64 start, u64 end, unsigned type)
> > +e820_any_mapped(unsigned long start,unsigned long end, unsigned type)
> >  {
> >  	int i;
> >  	for (i = 0; i < e820.nr_map; i++) {
> 
> This changes the parameters from 64bit to 32bit which looks fishy.

good catch! This could lead to bugs on 32-bit that has physical RAM 
addresses over 4GB.

> Are you sure the solution that would both match and be correct isn't 
> to change the 64bit one to u64?

agreed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/