linux-kernel - Re: w35und: fixed nasty stack overflow, I can actually ssh over this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 May 2008 14:35:36 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Pavel Machek <pavel@...e.cz>
Cc:	kernel list <linux-kernel@...r.kernel.org>, kaszak@...il.com,
	lcostantino@...il.com, linux-wireless@...r.kernel.org
Subject: Re: w35und: fixed nasty stack overflow, I can actually ssh over
	this


* Pavel Machek <pavel@...e.cz> wrote:

> Removed nasty stack overflow, and got transmit of big packets to work. 
> I can now actually do ssh over softmac-based driver.
> 
> Unindent code to make it more readable.

> --- a/arch/x86/kernel/traps_32.c
> +++ b/arch/x86/kernel/traps_32.c
> @@ -146,11 +146,16 @@ static inline unsigned long print_contex
>  				unsigned long *stack, unsigned long bp,
>  				const struct stacktrace_ops *ops, void *data)
>  {
> +	int max = 5;
>  	struct stack_frame *frame = (struct stack_frame *)bp;
>  
>  	while (valid_stack_ptr(tinfo, stack, sizeof(*stack))) {
>  		unsigned long addr;
>  
> +		if (!max)
> +			return;
> +		max--;
> +

hm, you got into an infinite loop here, right? Could you please send 
this bit as a separate patch - and i guess it should use 
kstack_depth_to_print instead of '5'?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/