linux-kernel - Re: [PATCH 24/56] microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48205C71.1000401@seznam.cz>
Date:	Tue, 06 May 2008 15:26:09 +0200
From:	Michal Simek <monstr@...nam.cz>
To:	Arnd Bergmann <arnd@...db.de>
CC:	John Williams <john.williams@...alogix.com>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	stephen.neuendorffer@...inx.com, John.Linn@...inx.com,
	matthew@....cx, will.newton@...il.com, drepper@...hat.com,
	microblaze-uclinux@...e.uq.edu.au, grant.likely@...retlab.ca
Subject: Re: [PATCH 24/56] microblaze_v2: time support

Hi Arnd,

I am not discouraged from negative comments. I got school from Wolfgang Denk on
U-BOOT project. (Thanks Wolfgang :-))

I only want to direct this to right way. That's all. And positive ACK to some
files give me better view what's wrong. :-)

Have a good day,
Michal


>> I saw a lot of comments about files but I have never seen any comments that
>> any file is OK.
>> Does it mean everything is broken??? I don't think so.
> 
> I've commented mostly on the header files defining the ABI. Since my aim
> is to have the ABI definition entirely in asm-generic/*.h, every exported
> file that has more than one line in it should be changed.
> 
> The files that implement the architecture support itself all look good
> to me, but since I'm not familiar with the architecture, I'm not trying
> to comment on them.
> 
> I think you're doing a great job on this. Any patch set of this size that
> has been maintained for a long time outside of the kernel goes through this
> phase where everyone tells you what to improve, based on their experience,
> while everything you do right about the patches is just taken for granted.
> 
> Don't let yourself get discouraged by the negative comments, we're really
> all just trying to help you do the right thing!
> 
>> I'll integrate reported bugs and send microblaze_v3 version.
> 
> Ok, thanks!
> 
> 	Arnd <><
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/