lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080507004702.d516a727.sfr@canb.auug.org.au>
Date:	Wed, 7 May 2008 00:47:02 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	John Williams <john.williams@...alogix.com>
Cc:	monstr@...nam.cz, linux-kernel@...r.kernel.org, arnd@...db.de,
	linux-arch@...r.kernel.org, stephen.neuendorffer@...inx.com,
	John.Linn@...inx.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 45/56] microblaze_v2: headers simple files - empty or
 redirect to asm-generic

On Mon, 05 May 2008 12:34:09 +1000 John Williams <john.williams@...alogix.com> wrote:
>
> 
> >  include/asm-microblaze/auxvec.h            |   14 ++++++++++++++
> >  include/asm-microblaze/cputime.h           |   16 ++++++++++++++++
> >  include/asm-microblaze/div64.h             |   16 ++++++++++++++++
> >  include/asm-microblaze/emergency-restart.h |   16 ++++++++++++++++
> >  include/asm-microblaze/errno.h             |   16 ++++++++++++++++
> >  include/asm-microblaze/futex.h             |   16 ++++++++++++++++
> >  include/asm-microblaze/kdebug.h            |   19 +++++++++++++++++++
> >  include/asm-microblaze/local.h             |   16 ++++++++++++++++
> >  include/asm-microblaze/mutex.h             |   16 ++++++++++++++++
> >  include/asm-microblaze/namei.h             |   24 ++++++++++++++++++++++++
> >  include/asm-microblaze/percpu.h            |   16 ++++++++++++++++
> >  include/asm-microblaze/resource.h          |   16 ++++++++++++++++
> >  include/asm-microblaze/user.h              |   18 ++++++++++++++++++
> 
> These are all just includes of asm-generic/* (hooray!).

Absolutely, but is it really necessary to have 14-16 lines of comment
(including a copyright notice) for a file whose single real line is just
to include another file?  i.e. reduce all these to 1 line files.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ