linux-kernel - Re: parisc DISCONTIGMEM compile breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080506152713.GA5034@csn.ul.ie>
Date:	Tue, 6 May 2008 16:27:14 +0100
From:	Mel Gorman <mel@....ul.ie>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Christoph Lameter <clameter@....com>,
	Lee Schermerhorn <lee.schermerhorn@...com>,
	kyle@...isc-linux.org, matthew@....cx, grundler@...isc-linux.org,
	linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: parisc DISCONTIGMEM compile breakage

On (06/05/08 16:46), Adrian Bunk didst pronounce:
> Commit 54a6eb5c4765aa573a030ceeba2c14e3d2ea5706
> (mm: use two zonelist that are filtered by GFP mask)
> causes the following build error with CONFIG_DISCONTIGMEM=y
> on parisc:
> 

Thanks Adrian. I don't have a pa-risc cross-compiler and there isn't one
at the usual source http://userweb.kernel.org/~akpm/cross-compilers but the
patch below should fix it. Note that this debugging code should be deleted if
the mm-initialisation-and-debugging framework in -mm is merged to mainline
as it knows how to print all the zonelists where as the pa-risc equivilant
misses the GFP_THISNODE lists.

=====
Subject: [PATCH] Fix pa-risc DISCONTIGMEM compile breakage
    
PA-RISC to aid debugging prints out the zonelists setup by the system. A
bad call to node_zonelist() breaks at compile-time. This patch fixes it.

Signed-off-by: Mel Gorman <mel@....ul.ie>
---
 arch/parisc/mm/init.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
index 1f01284..b0ed709 100644
--- a/arch/parisc/mm/init.c
+++ b/arch/parisc/mm/init.c
@@ -606,7 +606,7 @@ void show_mem(void)
 		int i, j;
 
 		for (i = 0; i < npmem_ranges; i++) {
-			zl = node_zonelist(i);
+			zl = node_zonelist(i, 0);
 			for (j = 0; j < MAX_NR_ZONES; j++) {
 				struct zoneref *z;
 				struct zone *zone;

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/