linux-kernel - Re: [PATCH] x86: fixed mtrr change WP to WB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482099E6.5060208@zytor.com>
Date:	Tue, 06 May 2008 10:48:22 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	yhlu.kernel@...il.com
CC:	Ingo Molnar <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: fixed mtrr change WP to WB

Yinghai Lu wrote:
> [PATCH] x86: fixed mtrr change WP to WB
> 
> so we modify mptable near below 1M
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>

Again:

This does not work on even the majority of all systems.

If the mptable should be modified, it should be copied to kernel memory 
and modified there.  Modifying it in-place is both unsafe and, in 
general, simply will not work.

Sorry.

NAK on this whole set.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/