linux-kernel - Re: [PATCH] x86: !x & y typo in mtrr code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4368.1210098257@turing-police.cc.vt.edu>
Date:	Tue, 06 May 2008 14:24:17 -0400
From:	Valdis.Kletnieks@...edu
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Björn Steinbrink <B.Steinbrink@....de>,
	Al Viro <viro@...IV.linux.org.uk>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>
Subject: Re: [PATCH] x86: !x & y typo in mtrr code

On Wed, 30 Apr 2008 08:35:34 PDT, Harvey Harrison said:
> On Wed, 2008-04-30 at 14:35 +0200, Ingo Molnar wrote:
> > We for one simply concentrate on the the things that we think makes it 
> > more likely to find bugs. For example we build and boot x86.git with 
> > many different configs before every pull request. In practice that 
> > catches far more tester-critical bugs than Sparse - and we know that 
> > simply from the fact because we use both methods and have a good 
> > comparison of the results. We also work on automating Sparse checks in 
> > the future but as i said it, it's not easy.
> > 
> 
> That's precisely why I've been sending all of the sparse cleanup patches
> lately, to try and get the output down to something more managable.  You
> may want to upgrade your sparse to one that understands __cold though.

What release of sparse would that be?  Fedora ships one tagged as 0.4.1-2.fc9,
but that says:

include/linux/kernel.h:135:52: error: attribute '__cold__': unknown attribute

But you go look at Documentation/sparse.txt and it points you to:

"You can get latest released versions from the Sparse homepage at
http://www.kernel.org/pub/linux/kernel/people/josh/sparse/ "

which says 0.4.1 is the latest released version.  So is this a git-only feature?

Content of type "application/pgp-signature" skipped