linux-kernel - Re: [PATCH] mm/cgroup.c add error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4820A431.3000600@firstfloor.org>
Date:	Tue, 06 May 2008 20:32:17 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
CC:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	Paul Menage <menage@...gle.com>, Li Zefan <lizf@...fujitsu.com>
Subject: Re: [PATCH] mm/cgroup.c add error check

KOSAKI Motohiro wrote:
>>  > on heavy workload, call_usermodehelper() may failure
>>  > because it use kzmalloc(GFP_ATOMIC).
>>
>>  Better just fix it to not use GFP_ATOMIC in the first place.
> 
> Ah, makes sense.
> I'll try toi create that patch.

Thanks.

> 
> but if GFP_KERNEL is used, We still need error check, IMHO.

Yes, but no retry (or if you're sure you cannot fail use __GFP_NOFAIL
too, but that is nasty because it has some risk of deadlock under severe
oom conditions)

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/