linux-kernel - Re: [PATCH] [POWERPC] Fix of_i2c include for module compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4820A5E9.8030204@scram.de>
Date:	Tue, 06 May 2008 20:39:37 +0200
From:	Jochen Friedrich <jochen@...am.de>
To:	Paul Mackerras <paulus@...ba.org>
CC:	Kumar Gala <galak@...nel.crashing.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Scott Wood <scottwood@...escale.com>,
	"Kernel, Linux" <linux-kernel@...r.kernel.org>,
	linuxppc-dev list <linuxppc-dev@...abs.org>,
	Linux I2C <i2c@...sensors.org>, Jon Smirl <jonsmirl@...il.com>,
	Laurent Pinchart <laurentp@...-semaphore.com>,
	David Miller <davem@...emloft.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] [POWERPC] Fix of_i2c include for module compilation

Hi Paul,

>> -#ifdef CONFIG_OF_I2C
>> +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE)
>>  
>>  void of_register_i2c_devices(struct i2c_adapter *adap,
>>  			     struct device_node *adap_node);
> 
> Why do we have that ifdef there at all?  There's only that one
> external declaration within it, so the #ifdef and #endif could just be
> removed.  If the ifdef hadn't been there in the first place we
> wouldn't have had this problem.

You're right. I mainly copied from of_gpio.h without too much thinking :(.
I'll resend.

Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/