linux-kernel - Re: [PATCH] clocksource: shift helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1210109441.17132.193.camel@localhost.localdomain>
Date:	Tue, 06 May 2008 14:30:41 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	akpm@...ux-foundation.org, johnstul@...ibm.com,
	ralf@...ux-mips.org, anemo@....ocn.ne.jp,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: shift helper


On Tue, 2008-05-06 at 23:19 +0200, Thomas Gleixner wrote:

> You - the patch submitter - have to provide useful information to
> those who review the patches and not the reviewers are supposed to
> decode your sloppy commit log.
> 
> "... which I pulled from the MIPS tree"
> 
> Why should I assume that this is from mainline ?

I'm not going to get into a long argument over this..

> > > I'm fine with the change itself, but it needs to move the code out of
> > > MIPS in the first place and not just duplicating code for no good
> > > reason.
> > 
> > I can work with Atsushi, but I still think the generic version should be
> > merged. We at least would need it in order to modify the mips code.
> 
> You can think what you want, it's not the way it works.
> 
> You duplicate code, so the first thing to do is to replace the code
> which you copied and make sure it is still fully functional. Then you
> can add a second user to make the point that the generic code move is
> actually useful. btw, pmtimer is the worst example for a good use case
> as everything there is constant so we can do it at compile time.

I can provide a patch that replaces the mips code instead of acpi_pm ..
Is that what your asking for?

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/