| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080506143936.6357e578.akpm@linux-foundation.org> Date: Tue, 6 May 2008 14:39:36 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: tony@...eyournoodle.com (Tony Breeds) Cc: linux-kernel@...r.kernel.org, benh@...nel.crashing.org Subject: Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c On Thu, 24 Apr 2008 14:34:01 +1000 tony@...eyournoodle.com (Tony Breeds) wrote: > Current kernel builds warn about: > drivers/video/aty/radeon_base.c: In function 'radeonfb_pci_register': > drivers/video/aty/radeon_base.c:2334: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result > drivers/video/aty/radeon_base.c:2336: warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result > > Do minimal checking of these functions and issue a warning if either > fails. They don't seem to be critical.. well OK, but I object to the patch title! The point isn't to silence warnings. It is to fix the problem which that warning is drawing our attention to. So I rewrote the title to "drivers/video/aty/radeon_base.c: notify user if sysfs_create_bin_file() failed". And your fix looks appropriate - if sysfs_create_bin_file() fails we will now get reports of this and we can find out what kernel bug caused this to happen. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists