lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 May 2008 08:01:05 +0200 From: Jean Delvare <khali@...ux-fr.org> To: Andrew Morton <akpm@...ux-foundation.org> Cc: djwong@...ibm.com, mhoffman@...htlink.com, linux-kernel@...r.kernel.org, lm-sensors@...sensors.org Subject: Re: [resend] [PATCH v2] ibmaem: New driver for power/energy meters in IBM System X hardware On Tue, 6 May 2008 17:36:07 -0700, Andrew Morton wrote: > A checkpatch version which you might not have says > > WARNING: consider using strict_strtol in preference to simple_strtol > #1015: FILE: drivers/hwmon/ibmaem.c:918: > + int temp = simple_strtol(buf, NULL, 10); \ > > total: 0 errors, 1 warnings, 1221 lines checked > > because the code as you have it will accept input of the form "12foo". > strict_strtol() will error on that. As a side note, I really wonder why this new function wasn't named just strtol(), especially if the general idea is to get rid of the "simple" variant after some time. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists