linux-kernel - Re: 2.6.26, PAT and AMD family 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 May 2008 13:16:41 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Rene Herman" <rene.herman@...access.nl>
Cc:	"Daniel Hazelton" <dhazelton@...er.net>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>, hpa@...or.com
Subject: Re: 2.6.26, PAT and AMD family 6

On Wed, May 7, 2008 at 1:06 PM, Rene Herman <rene.herman@...access.nl> wrote:
> On 07-05-08 21:39, Daniel Hazelton wrote:
>
>
> > HPA asked about why they used a whitelist instead of a blacklist in [1].
> The answer (in [2]) was that those are the CPU's that are guaranteed to
> properly support PAT (no known or potential errata). However in [3] Dean
> Gaudet complained about the AMD detection code having a limit that the Intel
> detection code did not.
> >
>
>  And in that thread both HPA and Ingo Molnar -- two of the three x86 arch
>  maintainers -- agreed that a whitelist is the wrong approach, with HPA
>  commenting that it lead to vendor lockin. And here I am talkng to an
>  Intel employee about why my entire AMD CPU family was excluded.
>
>  So why is this thing now in mainline with Ingo's sign-off and not a line
>  of changelog to explain it?
>
>
>
> >                     ^^^^^---- Here in Rene's patch...
> >
>
>  Yinghai's.
>
>
>
> > Wouldn't this be better if written the same as the Intel side, ie:
> > if (c->x86 >= 0xF && (c->x86 == 6 && c->x86_model == 7))
> > (or even with c->x86_model >= 7  ?)

i only can access opteron Rev E, Rev F, and Quad core. So i enabled that.

now, enable other one by one...

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/