linux-kernel - Re: 2.6.26, PAT and AMD family 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080507223918.GK18516@elf.ucw.cz>
Date:	Thu, 8 May 2008 00:39:18 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.26, PAT and AMD family 6

On Wed 2008-05-07 15:23:46, Yinghai Lu wrote:
> >  2) HPA said it was bad idea
> 
> hpa said white list is not a good idea.

And guess what your patch is doing?

+       switch (c->x86_vendor) {
+       case X86_VENDOR_AMD:
+               if (c->x86 >= 0xf && c->x86 <= 0x11)
+                       set_cpu_cap(c, X86_FEATURE_PAT);
+               break;
+       case X86_VENDOR_INTEL:
+               if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >=
15))
+                       set_cpu_cap(c, X86_FEATURE_PAT);
+               break;
+       }

Seems like a whitelist to me. Will break with future CPUs.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/