linux-kernel - Re: [PATCH] sched: fix SCHED_OTHER balance iterator to include all tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1210234285.13978.172.camel@twins>
Date:	Thu, 08 May 2008 10:11:25 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Gregory Haskins <ghaskins@...ell.com>,
	linux-kernel@...r.kernel.org, David Bahi <dbahi@...ell.com>
Subject: Re: [PATCH] sched: fix SCHED_OTHER balance iterator to include all
	tasks

On Tue, 2008-05-06 at 14:06 +0200, Ingo Molnar wrote:
> * Gregory Haskins <ghaskins@...ell.com> wrote:
> 
> > Hi Ingo,
> >  The follow patch applies to sched-devel.  I know the original 
> >  function was somehow trying to protect against dequeueing by 
> >  pre-iterating.  I am not sure if I captured the intent properly in 
> >  that regard.  What I can say is that the old algorithm would miss 
> >  tasks, and that is now fixed.  It may need further adjustment if I 
> >  missed the pre-iterating operation.
> > 
> > Hi Peter,
> >  I was wrong earlier when I mentioned there might be a problem with 
> >  entity_is_task().  I think this was the root cause of what I was 
> >  seeing. Sorry for the red-herring.
> 
> applied Gregory, thanks. Nice fix! Peter, do you concur with Gregory's 
> analysis?

Yeah,

Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/