[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080508101113.GB3267@erda.amd.com>
Date: Thu, 8 May 2008 12:11:14 +0200
From: Robert Richter <robert.richter@....com>
To: Arjan van de Ven <arjan@...radead.org>
Cc: stephane eranian <eranian@...glemail.com>,
linux-kernel@...r.kernel.org, ia64 <linux-ia64@...r.kernel.org>
Subject: Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available
On 29.04.08 09:42:18, Arjan van de Ven wrote:
> On Wed, 30 Apr 2008 15:51:39 +0200
> "stephane eranian" <eranian@...glemail.com> wrote:
>
> > If I recall, AMD said that this special initialization would
> > eventually migrate into the core kernel. The pci_read() may be there
> > because it was not exported by the kernel (this particular code lives
> > in a kernel module).
>
> ... yet your patch adds an EXPORT_SYMBOL() just to make this specific function possible. Weird.
>
> I find it hard to believe that there would be no code in the kernel to
> read or write config space of a device you have..... :)
> In fact I bet 80% of the drivers in the tree use it.
Access to extended config space for AMD northbridges was not yet
implemented. Recent patches from Yinghai Lu fix this. I will send a
patch that uses the in-kernel functions.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@....com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists