[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.1.10.0805081207050.3318@apollo.tec.linutronix.de>
Date: Thu, 8 May 2008 12:12:37 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: Andi Kleen <andi@...stfloor.org>
cc: Mirco Tischler <mt-ml@....de>, Ingo Molnar <mingo@...hat.com>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: [BUG]:WARNING: at arch/x86/kernel/rtc.c:122 in 2.6.26-rc1
On Thu, 8 May 2008, Andi Kleen wrote:
>
> > May 7 21:52:04 kernel: [4294896.091827] Extended CMOS year: 2000
> > May 7 21:52:04 kernel: [4294896.091827] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
> > May 7 21:52:04 kernel: [4294896.091827] Back to C!
> > May 7 21:52:04 kernel: [4294896.091827] Extended CMOS year: 2000
>
> If the data is read correctly (and it looks like it) then just the bit
> is wrong and we should ignore it I guess. So just remove the
> WARN_ON_ONCE()?
You put a printk there in the first place :) I changed it to
WARN_ON_ONCE as one line printks are more likely to be ignored.
I'm all for it to remove the while BCD check, which is hardcoded to
ALWAYS_BCD = 1 since linux 1.0.
This oddball case is interesting as it just triggered once and it
looks more like a hardware glitch than something we need to worry
about.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists