linux-kernel - RE: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C80EF34A3D2E494DBAF9AC29C7AE4EB806F67843@exchtp03.taipei.via.com.tw>
Date:	Thu, 8 May 2008 08:54:49 +0800
From:	<JosephChan@....com.tw>
To:	<alan@...rguk.ukuu.org.uk>
Cc:	<akpm@...ux-foundation.org>, <geert@...ux-m68k.org>,
	<linux-fbdev-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver

Hi Alan,

Thanks for your reviewing, 
I will push our engineers to check those things your mentioned and suggested.

BRs,
Joseph Chan 

-----Original Message-----
From: Alan Cox [mailto:alan@...rguk.ukuu.org.uk] 
Sent: Wednesday, May 07, 2008 11:21 PM
To: Joseph Chan
Cc: Joseph Chan; akpm@...ux-foundation.org; geert@...ux-m68k.org; linux-fbdev-devel@...ts.sourceforge.net; linux-kernel@...r.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver

> +void delays(int count);
> +void i2cWriteSdaScl(u8 sda, u8 scl);
> +void i2cWriteScl(u8 scl);
> +void i2cReadSdaScl(u8 *pSda, u8 *pScl);

Style is good, code looks clean

One big thing that needs fixing here is the function names. If the driver gets linked into the kernel then the symbols become global - and names like enableGPIO are asking for clashes. The viafb code is fine as it uses viafb_ as the function names. Possibly the helper functions should doo something similar.

We also have a generic i2c layer that might be usable but that is something that could be addressed in the future and isn't really an important detail.

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/