linux-kernel - Re: [PATCH] x86: introduce a new Linux defined feature flag for PAT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080508130838.GA13162@elte.hu>
Date:	Thu, 8 May 2008 15:08:39 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Rene Herman <rene.herman@...access.nl>,
	Adrian Bunk <bunk@...nel.org>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, Pavel Machek <pavel@...e.cz>
Subject: Re: [PATCH] x86: introduce a new Linux defined feature flag for
	PAT support


* Thomas Gleixner <tglx@...utronix.de> wrote:

> Subject: x86: cleanup PAT cpu validation
> From: Thomas Gleixner <tglx@...utronix.de>
> Date: Thu, 08 May 2008 09:18:43 +0200
> 
> Move the scattered checks for PAT support to a single function. Its 
> moved to addon_cpuid_features.c as this file is shared between 32 and 
> 64 bit.

thanks Thomas, i have applied your cleanup patch - looks good here too 
and it booted fine on a few boxes.

(i did a small cleanup: changed the define to static const int)

Peter, what are your plans for a more general cleanup and 32-bit/64-bit 
unification for the x86 CPU detection code - do you have any specific 
ideas already? I suspect we want it all to end up unified under 
arch/x86/kernel/cpu/, by moving the relevant bits of 
arch/x86/kernel/setup_64.c there, right? It is no small task for sure.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/