linux-kernel - Re: [PATCH] i2c: cs8427.c use put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hfxssykw0.wl%tiwai@suse.de>
Date:	Thu, 08 May 2008 15:40:15 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: cs8427.c use put_unaligned helper

At Wed, 07 May 2008 12:59:27 -0700,
Harvey Harrison wrote:
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

Thanks, applied to ALSA tree.


Takashi

> ---
>  sound/i2c/cs8427.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c
> index e57e9cb..9c3d361 100644
> --- a/sound/i2c/cs8427.c
> +++ b/sound/i2c/cs8427.c
> @@ -23,6 +23,7 @@
>  #include <linux/slab.h>
>  #include <linux/delay.h>
>  #include <linux/init.h>
> +#include <asm/unaligned.h>
>  #include <sound/core.h>
>  #include <sound/control.h>
>  #include <sound/pcm.h>
> @@ -264,10 +265,7 @@ int snd_cs8427_create(struct snd_i2c_bus *bus,
>  		goto __fail;
>  	}
>  	/* write default channel status bytes */
> -	buf[0] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 0));
> -	buf[1] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 8));
> -	buf[2] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 16));
> -	buf[3] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 24));
> +	put_unaligned_le32(SNDRV_PCM_DEFAULT_CON_SPDIF, buf);
>  	memset(buf + 4, 0, 24 - 4);
>  	if (snd_cs8427_send_corudata(device, 0, buf, 24) < 0)
>  		goto __fail;
> -- 
> 1.5.5.1.404.g981f6
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/