linux-kernel - Re: [patch, -git] drivers/media build fix for modular builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48230C7B.90007@mandriva.org>
Date:	Thu, 08 May 2008 17:21:47 +0300
From:	Thomas Backlund <tmb@...driva.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	Linus <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Ingo Molnar <mingo@...e.hu>, linux-dvb-maintainer@...uxtv.org,
	video4linux-list@...hat.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch, -git] drivers/media build fix for modular builds

Stephen Rothwell skrev:
> Date:	Wed, 30 Apr 2008 09:48:07 +0200
> From:	Ingo Molnar <mingo@...e.hu>
> To:	Mauro Carvalho Chehab <mchehab@...radead.org>
> Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
> 	Andrew Morton <akpm@...ux-foundation.org>,
> 	linux-dvb-maintainer@...uxtv.org, video4linux-list@...hat.com,
> 	linux-kernel@...r.kernel.org
> 
> fix allmodconfig build bug introduced in latest -git by commit 
> 7c91f0624a9 ("V4L/DVB(7767): Move tuners to common/tuners"):
> 
>   LD      kernel/built-in.o
>   LD      drivers/built-in.o
>   ld: drivers/media/built-in.o: No such file: No such file or directory
> 
> which happens if all media drivers are modular:
> 
>   http://redhat.com/~mingo/misc/config-Wed_Apr_30_09_24_48_CEST_2008.bad
> 
> In that case there's no obj-y rule connecting all the built-in.o files and
> the link tree breaks.
> 
> the fix is to add a guaranteed obj-y rule for the core vmlinux to build.
> (which results in an empty object file if all media drivers are modular)
> 
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> Acked-by: Sam Ravnborg <sam@...nborg.org>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  drivers/media/Makefile |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Linus,
> 
> I have been applying a similar patch to linux-next for some time.  It has
> been reported a while ago and does break (at least) powerpc and x86_64
> allmodconfig builds.
> 
> Please apply at you earliest convenience.
> 
> /me tries out his "random-build-fix-monkey" appointment.
> 
> Index: linux/drivers/media/Makefile
> ===================================================================
> --- linux.orig/drivers/media/Makefile
> +++ linux/drivers/media/Makefile
> @@ -2,6 +2,8 @@
>  # Makefile for the kernel multimedia device drivers.
>  #
>  
> +obj-y := common/
> +
>  obj-$(CONFIG_VIDEO_MEDIA) += common/
>  
>  # Since hybrid devices are here, should be compiled if DVB and/or V4L
> 


How about fixing this one already ?

--
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/