linux-kernel - Re: [patch 04/24] reiserfs: dont call notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080508164910.GA13914@infradead.org>
Date:	Thu, 8 May 2008 12:49:10 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, hch@...radead.org,
	viro@...IV.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jeff Mahoney <jeffm@...e.de>
Subject: Re: [patch 04/24] reiserfs: dont call notify_change

On Tue, May 06, 2008 at 11:13:31AM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> Reiserfs calls notify_change() on it's private extended attribute
> files to resize and change ownership of these files.  Replace with
> reiserfs_setattr().
> 
> This is equivalent, except that:
> 
>  - i_alloc_sem locking is not performed around reiserfs_setattr() when
>    the size is changed
>  - security_inode_setattr() is not called before reiserfs_setattr()
>  - fsnotify_change() is not called after reiserfs_setattr()
> 
> None of the above is necessary, since the files are private to
> reiserfs and inaccessible from userspace.
> 
> Also remove setting of ctime on the xattr files.

I think splitting out the ATTR_SIZE case of reiserfs_setattr into
a separate helper would be better.  That would a) avoid the useless
c and mtime updates on the attribue inode and b) clean up
reiserfs_setattr a little bit.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/