linux-kernel - Re: [patch 00/16] Linux 2.6.25 -stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080508194314.GA31149@suse.de>
Date:	Thu, 8 May 2008 12:43:14 -0700
From:	Greg KH <gregkh@...e.de>
To:	Len Brown <lenb@...nel.org>
Cc:	Willy Tarreau <w@....eu>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Len Brown <len.brown@...el.com>
Subject: Re: [patch 00/16] Linux 2.6.25 -stable review

On Thu, May 08, 2008 at 03:16:28PM -0400, Len Brown wrote:
> On Thursday 08 May 2008, Willy Tarreau wrote:
> > On Thu, May 08, 2008 at 11:22:33AM -0700, Greg KH wrote:
> > > On Thu, May 08, 2008 at 08:13:42PM +0200, Willy Tarreau wrote:
> > > > On Thu, May 08, 2008 at 10:41:22AM -0700, Greg KH wrote:
> > > > > This is the start of the stable review cycle for the 2.6.25.2 release.
> > > > > There are 16 patches in this series, all will be posted as a response to
> > > > > this one.  If anyone has any issues with these being applied, please let
> > > > > us know.  If anyone is a maintainer of the proper subsystem, and wants
> > > > > to add a Signed-off-by: line to the patch, please respond with it.
> > > > 
> > > > Greg, shouldn't we also queue this one (may be in a later version) ? It's
> > > > in mainline.
> > > 
> > > What problem does it solve?
> > 
> > from what I see in the code, currently acpi_power_get_state() will return
> > 0 when setting resource to NULL, and some callers (eg: acpi_power_on())
> > will happily dereference resource if acpi_power_get_state() returns 0. So
> > I guess there are circumstances where we can oops.
> > 
> > > Does Len want it in -stable?
> > 
> > I simply forgot to ask. I'm CCing him.
> 
> This patch is correct.
> 
> Go ahead and apply it -- it won't hurt anything.
> I don't think it will help anything in real-life either, though.

Ok, because of that, I'll not apply it, we want patches that actually
fix reported problems.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/