linux-kernel - Re: [PATCH] x86: introduce a new Linux defined feature flag for PAT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805071923030.3024@woody.linux-foundation.org>
Date:	Wed, 7 May 2008 19:24:35 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"H. Peter Anvin" <hpa@...or.com>
cc:	Rene Herman <rene.herman@...access.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Adrian Bunk <bunk@...nel.org>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, Pavel Machek <pavel@...e.cz>
Subject: Re: [PATCH] x86: introduce a new Linux defined feature flag for PAT
 support



On Wed, 7 May 2008, H. Peter Anvin wrote:
> 
> Indeed it wasn't, and at least I have no interest of maintaining what is in
> effect an in-kernel version of x86info(1).

Umm. We already do, since we effectively ignore what the actual hardware 
says, and replace it with our own version.

> *Certainly* I don't want anything like this crap:
> 
> > -    if (cpu_has_pat)
> > +    if (cpu_has_pat && cpu_has_pat_good)

This in fact is likely the best part of it.

Because that at least guarantees that we never say we have a good PAT when 
the hardware doesn't even report it.

As it is, we seem to just blindly override hardware. It may be correct for 
all the models we override, but still..

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/