linux-kernel - Re: GIT bisection range errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adave1oqslr.fsf@cisco.com>
Date:	Thu, 08 May 2008 16:33:04 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Ken Moffat <zarniwhoop@...world.com>
Cc:	Rene Herman <rene.herman@...access.nl>,
	Adrian Bunk <bunk@...nel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: GIT bisection range errors

 > > $ git checkout -b rc v2.6.26-rc1
 > > $ git bisect start
 > > $ git bisect bad
 > > $ git bisect good v2.6.25
 > >
 > > Yet, during this I'm finding myself at 2.6.25-rc6 and 2.6.25-rc8
 > > as the last two results (both good...).

 >  I reported a similar thing at the beginning of April
 > http://lkml.org/lkml/2008/4/2/390 - 2.6.25-rc1 bad, 2.6.24 good, git
 > dropped me back at 2.6.24-rc4 (again, according to the top level
 > Makefile).

This is normal and expected, due to the distributed nature of git and
the fact that git-bisect operates on the full topology of history and
not just a linear sequence of commits.

Imagine history like:

    A---B---C---D
     \         /
      \       /
       \     /
        E---F

where B is good and D is bad.  Now, when you bisect, there is no way to
know whether, say, E is good or bad and hence the bisect process may
present E as a tree to try.

Now, if B is the 2.6.25 release, then since E branched off before B, it
will have a Makefile that says 2.6.25-rcX.  Which is exactly the
behavior you are seeing.

In short, everything looks fine and is behaving as expected.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/