| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080509132014.3379ae2f@hyperion.delvare>
Date: Fri, 9 May 2008 13:20:14 +0200
From: Jean Delvare <khali@...ux-fr.org>
To: linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org,
Stephen Tweedie <sct@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Jens Axboe <axboe@...nel.dk>
Subject: [PATCH] Fix misuses of bdevname()
bdevname() fills the buffer that it is given as a parameter, so
calling strcpy() or snprintf() on the returned value is redundant (and
probably not guaranteed to work - I don't think strcpy and snprintf
support overlapping buffers.)
Signed-off-by: Jean Delvare <khali@...ux-fr.org>
Cc: Stephen Tweedie <sct@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Jens Axboe <axboe@...nel.dk>
---
block/blktrace.c | 2 +-
block/compat_ioctl.c | 2 +-
fs/ext4/mballoc.c | 6 ++----
fs/jbd2/journal.c | 4 ++--
4 files changed, 6 insertions(+), 8 deletions(-)
--- linux-2.6.26-rc1.orig/block/blktrace.c 2008-05-09 12:52:51.000000000 +0200
+++ linux-2.6.26-rc1/block/blktrace.c 2008-05-09 12:55:04.000000000 +0200
@@ -476,7 +476,7 @@ int blk_trace_ioctl(struct block_device
switch (cmd) {
case BLKTRACESETUP:
- strcpy(b, bdevname(bdev, b));
+ bdevname(bdev, b);
ret = blk_trace_setup(q, b, bdev->bd_dev, arg);
break;
case BLKTRACESTART:
--- linux-2.6.26-rc1.orig/block/compat_ioctl.c 2008-05-09 12:52:51.000000000 +0200
+++ linux-2.6.26-rc1/block/compat_ioctl.c 2008-05-09 12:55:04.000000000 +0200
@@ -555,7 +555,7 @@ static int compat_blk_trace_setup(struct
if (copy_from_user(&cbuts, arg, sizeof(cbuts)))
return -EFAULT;
- strcpy(b, bdevname(bdev, b));
+ bdevname(bdev, b);
buts = (struct blk_user_trace_setup) {
.act_mask = cbuts.act_mask,
--- linux-2.6.26-rc1.orig/fs/ext4/mballoc.c 2008-05-09 12:52:51.000000000 +0200
+++ linux-2.6.26-rc1/fs/ext4/mballoc.c 2008-05-09 12:55:04.000000000 +0200
@@ -2639,8 +2639,7 @@ static int ext4_mb_init_per_dev_proc(str
struct proc_dir_entry *proc;
char devname[64];
- snprintf(devname, sizeof(devname) - 1, "%s",
- bdevname(sb->s_bdev, devname));
+ bdevname(sb->s_bdev, devname);
sbi->s_mb_proc = proc_mkdir(devname, proc_root_ext4);
MB_PROC_HANDLER(EXT4_MB_STATS_NAME, stats);
@@ -2674,8 +2673,7 @@ static int ext4_mb_destroy_per_dev_proc(
if (sbi->s_mb_proc == NULL)
return -EINVAL;
- snprintf(devname, sizeof(devname) - 1, "%s",
- bdevname(sb->s_bdev, devname));
+ bdevname(sb->s_bdev, devname);
remove_proc_entry(EXT4_MB_GROUP_PREALLOC, sbi->s_mb_proc);
remove_proc_entry(EXT4_MB_STREAM_REQ, sbi->s_mb_proc);
remove_proc_entry(EXT4_MB_ORDER2_REQ, sbi->s_mb_proc);
--- linux-2.6.26-rc1.orig/fs/jbd2/journal.c 2008-05-09 12:52:51.000000000 +0200
+++ linux-2.6.26-rc1/fs/jbd2/journal.c 2008-05-09 12:55:04.000000000 +0200
@@ -901,7 +901,7 @@ static void jbd2_stats_proc_init(journal
{
char name[BDEVNAME_SIZE];
- snprintf(name, sizeof(name) - 1, "%s", bdevname(journal->j_dev, name));
+ bdevname(journal->j_dev, name);
journal->j_proc_entry = proc_mkdir(name, proc_jbd2_stats);
if (journal->j_proc_entry) {
proc_create_data("history", S_IRUGO, journal->j_proc_entry,
@@ -915,7 +915,7 @@ static void jbd2_stats_proc_exit(journal
{
char name[BDEVNAME_SIZE];
- snprintf(name, sizeof(name) - 1, "%s", bdevname(journal->j_dev, name));
+ bdevname(journal->j_dev, name);
remove_proc_entry("info", journal->j_proc_entry);
remove_proc_entry("history", journal->j_proc_entry);
remove_proc_entry(name, proc_jbd2_stats);
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists