lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 May 2008 14:13:26 +0100 From: Andy Whitcroft <apw@...dowen.org> To: Eric Sesterhenn <snakebyte@....de> Cc: linux-kernel@...r.kernel.org, akpm@...l.org, zippel@...ux-m68k.org Subject: Re: [Patch] hfsplus oops on image without extends On Wed, May 07, 2008 at 12:42:44PM +0200, Eric Sesterhenn wrote: > hi, > > the following patch fixes an oops with a corrupted hfs+ image. > see http://bugzilla.kernel.org/show_bug.cgi?id=10548 for details. > > Problem is that we call hfs_btree_open() from hfsplus_fill_super() to set > HFSPLUS_SB(sb).[ext_tree|cat_tree] > Both trees are still NULL at this moment. If hfs_btree_open() fails for > any reason it calls iput() on the page, which > gets to hfsplus_releasepage() which tries to access HFSPLUS_SB(sb).* > which is still NULL and oopses while dereferencing it. > > > Signed-off-by: Eric Sesterhenn <snakebyte@....de> > > --- linux-2.6/fs/hfsplus/inode.c.orig 2008-05-07 14:37:31.000000000 +0200 > +++ linux-2.6/fs/hfsplus/inode.c 2008-05-07 14:38:05.000000000 +0200 > @@ -65,6 +65,8 @@ static int hfsplus_releasepage(struct pa > BUG(); > return 0; > } > + it (!tree) > + return 0; Erm, I presume this is meant to be 'if', checkpatch whined about the space as it thought it was a function. I guess this hasn't been compile tested? > if (tree->node_size >= PAGE_CACHE_SIZE) { > nidx = page->index >> (tree->node_size_shift - PAGE_CACHE_SHIFT); > spin_lock(&tree->hash_lock); -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists