[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1210354083.24092.5.camel@brick>
Date: Fri, 09 May 2008 10:28:03 -0700
From: Harvey Harrison <harvey.harrison@...il.com>
To: David Howells <dhowells@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/9] frv: gdb-stub.c use the common ascii hex helpers
On Fri, 2008-05-09 at 13:07 +0100, David Howells wrote:
> Harvey Harrison <harvey.harrison@...il.com> wrote:
>
> > Everyone rolls their own version around the tree, centralize
> > in lib/hexdump.c
>
> Can you instruct that these are only to be used for GDB stubs? Otherwise if
> someone slaps a breakpoint in there accidentally, they might kill the GDB
> stub.
>
This isn't a problem for hex_asc_{hi|lo} obviously, just the
hexchar_to_int function, I've been looking at making this available in
another way due to its similarity to simple_strtol etc (akpm noticed).
So the hex_asc_hi/lo helpers are probably useful as-is. I'll make
sure to note the effects on gdb as you've pointed out when I send
out the revised usage.
Cheers,
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists